This is an archive of the discontinued LLVM Phabricator instance.

Differential D67815

[LNT] Python 3 support: adapt to filter returning an iterator
ClosedPublic

Authored by thopre on Sep 20 2019, 1:35 AM.

Details

Reviewers
cmatthews
hubert.reinterpretcast
kristof.beyls
Commits
rL372819: [LNT] Python 3 support: adapt to filter returning an iterator
Summary

Adapt calls to filter() to the fact it returns an iterator in Python 3. This
was produced by running futurize's stage2 lib2to3.fixes.fix_filter.

Diff Detail

Repository
rL LLVM

Event Timeline

thopre created this revision.Sep 20 2019, 1:35 AM
thopre added a parent revision: D67814: [LNT] Python 3 support: adapt to dict method returning views.Sep 20 2019, 1:35 AM
thopre added a child revision: D67816: [LNT] Python 3 support: use int() instead of long().
Harbormaster completed remote builds in B38340: Diff 220973.Sep 20 2019, 1:42 AM
hubert.reinterpretcast accepted this revision.Sep 20 2019, 11:35 AM

LGTM.

This revision is now accepted and ready to land.Sep 20 2019, 11:35 AM
thopre retitled this revision from [LNT] Python 3 support: adapt to filter returning a view to [LNT] Python 3 support: adapt to filter returning an iterator.Sep 23 2019, 2:55 PM
thopre edited the summary of this revision. (Show Details)
thopre edited parent revisions, added: D67967: [LNT] rename object variables; removed: D67814: [LNT] Python 3 support: adapt to dict method returning views.Sep 24 2019, 8:50 AM
Closed by commit rL372819: [LNT] Python 3 support: adapt to filter returning an iterator (authored by thopre). · Explain WhySep 25 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 25 2019, 12:51 AM

Revision Contents

PathSize
lnt/
trunk/
lnt/
server/
reporting/
2 lines

Diff 221681

lnt/trunk/lnt/server/reporting/summaryreport.py

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines def build(self, session):
# patterns. # patterns.
def should_be_in_report(machine): def should_be_in_report(machine):
if machine.name in self.report_machine_names: if machine.name in self.report_machine_names:
return True return True
for rex in self.report_machine_rexes: for rex in self.report_machine_rexes:
if rex.match(machine.name): if rex.match(machine.name):
return True return True
self.requested_machines = dict( self.requested_machines = dict(
(ts, filter(should_be_in_report, session.query(ts.Machine).all())) (ts, list(filter(should_be_in_report, session.query(ts.Machine).all())))
for ts in self.testsuites) for ts in self.testsuites)
self.requested_machine_ids = dict( self.requested_machine_ids = dict(
(ts, [m.id for m in machines]) (ts, [m.id for m in machines])
for ts, machines in self.requested_machines.items() for ts, machines in self.requested_machines.items()
) )
# First, collect all the runs to summarize on, for each index in the # First, collect all the runs to summarize on, for each index in the
# report orders. # report orders.
▲ Show 20 Lines • Show All 375 Lines • Show Last 20 Lines