This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Rename minnan and maxnan to minimum and maximum
ClosedPublic

Authored by tlively on Oct 10 2018, 2:57 PM.

Details

Summary

Changes all uses of minnan/maxnan to minimum/maximum
globally. These names emphasize that the semantic difference between
these operations is more than just NaN-propagation.

Diff Detail

Event Timeline

tlively created this revision.Oct 10 2018, 2:57 PM
  • I guess this should be marked as NFC
  • Does this mean you'd like to match the semantics of the existing minnan/maxnan in the backend to match the new minimum/maximum intrinsics? Then are you planning to update ValueTracking optimizations for them as well?
lib/Target/AArch64/AArch64ISelLowering.cpp
389

For Promote, I guess we can honor the existing indentation (even though clang-format does not like it)

820

I know it is pre-existing, but as we are modifying it anyway, we can clang-format I guess

test/CodeGen/WebAssembly/simd-arith.ll
804

Why is the operand order changed? The same for three more changes below this

tlively retitled this revision from Rename minnan and maxnan to minimum and maximum to [NFC] Rename minnan and maxnan to minimum and maximum.Oct 19 2018, 3:22 PM
  • I guess this should be marked as NFC

Done

  • Does this mean you'd like to match the semantics of the existing minnan/maxnan in the backend to match the new minimum/maximum intrinsics? Then are you planning to update ValueTracking optimizations for them as well?

This semantic matching already happened when we merged the new intrinsics, since they already lower directly to these SD nodes. I was not planning on updating the ValueTracking optimizations, although I could look into it. The current optimizations are still correct because they are too conservative, if anything.

tlively updated this revision to Diff 170267.Oct 19 2018, 3:40 PM
tlively marked 2 inline comments as done.
  • Formatting
aheejin accepted this revision.Oct 19 2018, 5:05 PM
This revision is now accepted and ready to land.Oct 19 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.