Page MenuHomePhabricator

[DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type.
AbandonedPublic

Authored by Chirag on Jul 18 2018, 10:28 PM.

Details

Summary

Added unsigned endianity field to hold DW_AT_endianity in DIBasicType with default constructor support listed as per DWARF v4.
This is part of initial work which will extend to LLParser, ASMParser/Writer to read/write endianity to/from asm/obj file, also to the api DICreateBasicType to support endianity with default parameter.

Diff Detail

Event Timeline

Chirag created this revision.Jul 18 2018, 10:28 PM

Hello All,

Apologies in advance if review is not posted properly.

Regards,
Chirag Patel.

I don't necessarily think this should be part of DIBasicType since it'll be used almost never. Adding other reviewers to get thoughts on location.

-eric

Probably squirrel it away in the generic 'flags' bucket?

Probably squirrel it away in the generic 'flags' bucket?

Seems reasonable to me. Might need a tristate or something, but that's what enums and masking are for.

Probably squirrel it away in the generic 'flags' bucket?

Seems reasonable to me. Might need a tristate or something, but that's what enums and masking are for.

SGTM too.

Chirag added a comment.EditedJul 20 2018, 2:48 AM

Thank you guys for the help.

I will try and use DIFlags instead.
I will wait for adrian for any comment.

Regards,
Chirag Patel.

Chirag abandoned this revision.Jul 23 2018, 11:44 PM

Hello Adrian,
can i discard this review?