This is an archive of the discontinued LLVM Phabricator instance.

Flip the order the preprocessor and frontendaction are informed of the end of a file.
ClosedPublic

Authored by bkramer on Aug 4 2014, 4:56 AM.

Diff Detail

Event Timeline

bkramer updated this revision to Diff 12153.Aug 4 2014, 4:56 AM
bkramer retitled this revision from to Flip the order the preprocessor and frontendaction are informed of the end of a file..
bkramer updated this object.
bkramer added reviewers: alexfh, klimek, djasper.
bkramer added a subscriber: Unknown Object (MLST).
klimek edited edge metadata.Aug 4 2014, 5:05 AM

I'm fine with it - we might want to ask Richard whether he can imagine any problems with this change...

rsmith edited edge metadata.Aug 7 2014, 11:01 AM

This seems like a more natural order for these actions to me. Can you add a test? (Install a preprocessing callback and check that its EndOfMainFile action is called before the FrontendAction's EndSourceFileAction)

bkramer updated this revision to Diff 12288.Aug 7 2014, 1:33 PM
bkramer edited edge metadata.

Added unit test.

bkramer closed this revision.Aug 7 2014, 2:00 PM
bkramer updated this revision to Diff 12290.

Closed by commit rL215145 (authored by d0k).