This is an archive of the discontinued LLVM Phabricator instance.

Avoid referencing a vtable when not required
ClosedPublic

Authored by rnk on Jul 8 2014, 6:19 PM.

Details

Summary

This fixes compilation errors about incomplete types used with WebKit's
RefPtr template. Simply calling an out of line constructor should not
instantiate all inline and defaulted virtual methods.

Diff Detail

Event Timeline

rnk updated this revision to Diff 11178.Jul 8 2014, 6:19 PM
rnk retitled this revision from to Avoid referencing a vtable when not required.
rnk updated this object.
rnk added a reviewer: rsmith.
rnk added a subscriber: Unknown Object (MLST).
thakis added a subscriber: thakis.Jul 8 2014, 6:26 PM

(fixes PR20221)

rnk updated this object.Jul 8 2014, 6:42 PM
rnk added a comment.Jul 11 2014, 11:37 AM

Ping. I think we agreed this was safe.

rsmith accepted this revision.Jul 14 2014, 8:41 PM
rsmith edited edge metadata.

I think I've convinced myself that this is fine, but please test it against some large projects before committing.

This revision is now accepted and ready to land.Jul 14 2014, 8:41 PM
rnk closed this revision.Jul 15 2014, 5:39 PM
rnk updated this revision to Diff 11479.

Closed by commit rL213109 (authored by @rnk).