This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Suggest including <cmath> if necessary in type-promotion-in-math-fn-check.
ClosedPublic

Authored by jlebar on Dec 13 2016, 9:59 PM.

Event Timeline

jlebar updated this revision to Diff 81347.Dec 13 2016, 9:59 PM
jlebar retitled this revision from to [clang-tidy] Suggest including <cmath> if necessary in type-promotion-in-math-fn-check..
jlebar updated this object.
jlebar added a reviewer: alexfh.
jlebar added a subscriber: cfe-commits.
alexfh accepted this revision.Dec 13 2016, 10:05 PM
alexfh edited edge metadata.
alexfh added inline comments.
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp
187

s/D/Diag/

198

Remove all spaces inside the argument comment, it's more common that way and clang-format understand it better.

This revision is now accepted and ready to land.Dec 13 2016, 10:05 PM

LG with a couple of nits.

jlebar marked 2 inline comments as done.Dec 13 2016, 11:02 PM

Thank you for the review, @alexfh. I will commit with these changes.

clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp
198

Done, but FWIW it seems that clang-format will not insert a linebreak between the comment and the arg even with the spaces. It is much more common in llvm, though, as you say.

This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.