Add no-op functions for non-x86 paths.

[asbirlea]

Summary

Stub functions for non-x86.

[echristo]

Might be best to pull this temporarily and reorganize so it's not visible at all for non-x86 - it shouldn't be and apparently I missed that in review. My apologies.

Can you submit a follow-on patch that organizes all of the routines so that they have fewer nested ifdefs etc?

All of this shouldn't be external for anything not x86 and this patch is just papering over it.

Thanks.

-eric

[lhames]

Might be best to pull this temporarily...

It would be great to get the bots back to green - can the original commit be temporarily reverted while this is sorted out?

• Lang.

[echristo]

In D22174#478867, @lhames wrote:

Might be best to pull this temporarily...

It would be great to get the bots back to green - can the original commit be temporarily reverted while this is sorted out?

• Lang.

In progress :)

git svn lost its brain on Alina's machine.

-eric

[lhames]

Oh dear.

My best wishes for a speedy return to sanity. :)

• Lang.

lib/builtins/cpu_model.c

#elif defined(_MSC_FULL_VER) && defined(_XCR_XFEATURE_ENABLED_MASK)
   *rEAX = Result;
   *rEDX = Result >> 32;
   return false;
 #else
   return true;
 #endif
 }
 
+#else
+/// No-op stub functions
+static bool getX86CpuIDAndInfo(unsigned value, unsigned *rEAX, unsigned *rEBX,
+                               unsigned *rECX, unsigned *rEDX) {
+  return true;
+}
+static bool getX86CpuIDAndInfoEx(unsigned value, unsigned subleaf,
+                                 unsigned *rEAX, unsigned *rEBX, unsigned *rECX,
+                                 unsigned *rEDX) {
+  return true;
+}
+static bool getX86XCR0(unsigned *rEAX, unsigned *rEDX) {
+  return true;
+}
 #endif
 
 static void detectX86FamilyModel(unsigned EAX, unsigned *Family,
                                  unsigned *Model) {
   *Family = (EAX >> 8) & 0xf; // Bits 8 - 11
   *Model = (EAX >> 4) & 0xf;  // Bits 4 - 7
   if (*Family == 6 || *Family == 0xf) {
     if (*Family == 0xf)