This is an archive of the discontinued LLVM Phabricator instance.

[cpu-detection] Naming convention
ClosedPublic

Authored by asbirlea on Jun 3 2016, 10:03 AM.

Details

Summary

Follow-up to D20926 (committed as r271595, r271596).
This patch is in preparation for a substantial refactoring of the code.

No functionality changed.

Update comment after clang format

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea updated this revision to Diff 59575.Jun 3 2016, 10:03 AM
asbirlea retitled this revision from to [cpu-detection] Naming convention.
asbirlea updated this object.
echristo edited edge metadata.Jun 3 2016, 12:22 PM

One inline comment.

-eric

lib/Support/Host.cpp
189–190 ↗(On Diff #59575)

Why are you changing the references to pointers?

asbirlea added inline comments.Jun 3 2016, 12:33 PM
lib/Support/Host.cpp
189–190 ↗(On Diff #59575)
  1. Consistency withe the above methods.
  2. Planning to port the same code into compiler-rt/ as ***.c (it will address Bug 25510).
echristo added inline comments.Jun 3 2016, 12:44 PM
lib/Support/Host.cpp
189–190 ↗(On Diff #59575)

I'd almost rather change the other methods :)

And I believe we can use c++ in compiler-rt - at least the sanitizers do.

asbirlea added inline comments.Jun 3 2016, 1:15 PM
lib/Support/Host.cpp
189–190 ↗(On Diff #59575)

Planning to add to lib/builtins, which appears C only.
Keeping the code close to what will go in compiler-rt seemed a good idea.

echristo accepted this revision.Jun 3 2016, 1:16 PM
echristo edited edge metadata.

LGTM.

Thanks!

lib/Support/Host.cpp
189–190 ↗(On Diff #59575)

That seems like a good idea for now.

This revision is now accepted and ready to land.Jun 3 2016, 1:16 PM
This revision was automatically updated to reflect the committed changes.