This patch is in preparation for a substantial refactoring of the code. No functionality changed.
To make the diffs easier to read, I'm planning to first get everything using clang-format, then get the naming conventions consistent, and finally post the more substantial refactoring patch.
Details
- Reviewers
echristo craig.topper • ddunbar
Diff Detail
Event Timeline
| lib/Support/Host.cpp | ||
|---|---|---|
| 194 | I liked the alignment with the line above. | |
| 224 | I liked those equal signs being aligned. | |
| 236 | This looks odd. Why did clang-format decide on a new break here? | |
| 789 | I don't really like the = signs becoming unaligned here and in the later code. They emphasized the similarity of the code. | |
| 896 | Why did clang format collapse this enum? That seems odd. | |
| lib/Support/Host.cpp | ||
|---|---|---|
| 789 | FWIW I sortof agree, that said, this code is going to get a little nicer here shortly and the formatting is just to make it easier to review :) | |
| 896 | I've gone ahead and committed this already under the "clang-format is always ok" rule, but I'd love to see bugs filed against clang-format if you don't agree with it :) | |
| lib/Support/Host.cpp | ||
|---|---|---|
| 789 | Honestly, I agree as well. I'm open to realign the = signs after the reformatting patch, assuming it's preferable to clang format. | |
| lib/Support/Host.cpp | ||
|---|---|---|
| 236 | Probably it prefers to break after '=' rather than '&&' given that the entire RHS will still fit in 80 columns. | |
I liked the alignment with the line above.