This is an archive of the discontinued LLVM Phabricator instance.

[llvm-pdbdump] Introduce an abstraction for the output style.
ClosedPublic

Authored by zturner on Jun 3 2016, 8:37 AM.

Details

Summary
[llvm-pdbdump] Introduce an abstraction for the output style.

This opens the door to introducing a YAML outputter which can be
used for machine consumption.  Currently the yaml output style
is unimplemented and returns an error if you try to use it.

Diff Detail

Event Timeline

zturner updated this revision to Diff 59563.Jun 3 2016, 8:37 AM
zturner retitled this revision from to [llvm-pdbdump] Introduce an abstraction for the output style..
zturner updated this object.
zturner added reviewers: rnk, ruiu, majnemer.
zturner added a subscriber: llvm-commits.
zturner updated this revision to Diff 59564.Jun 3 2016, 8:41 AM

Remove the PDBFile& argument from each dump method and just store it in the class.

rnk accepted this revision.Jun 3 2016, 9:00 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jun 3 2016, 9:00 AM
ruiu accepted this revision.Jun 3 2016, 10:58 AM
ruiu edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.