This is an archive of the discontinued LLVM Phabricator instance.

[x86] avoid printing unnecessary sign bits of hex immediates in asm comments (PR20347)
ClosedPublic

Authored by spatel on May 18 2016, 2:22 PM.

Details

Summary

It would probably be better to check the valid/expected size of the immediate operand, but I don't see a way to do that.

Diff Detail

Event Timeline

spatel updated this revision to Diff 57676.May 18 2016, 2:22 PM
spatel retitled this revision from to [x86] avoid printing unnecessary sign bits of hex immediates in asm comments (PR20347).
spatel updated this object.
spatel added reviewers: craig.topper, enderby, RKSimon.
spatel added a subscriber: llvm-commits.
RKSimon edited edge metadata.May 27 2016, 5:12 AM

Do we have a similar issue with Intel syntax?

Do we have a similar issue with Intel syntax?

We would, except that we don't print any comments at all for Intel syntax. :)
I can make that a TODO / follow-up.

RKSimon accepted this revision.May 27 2016, 7:08 AM
RKSimon edited edge metadata.

Do we have a similar issue with Intel syntax?

We would, except that we don't print any comments at all for Intel syntax. :)
I can make that a TODO / follow-up.

OK - please can you raise a bugzilla about improving intel assembly comments (and reference this patch)?

LGTM.

This revision is now accepted and ready to land.May 27 2016, 7:08 AM

OK - please can you raise a bugzilla about improving intel assembly comments (and reference this patch)?

https://llvm.org/bugs/show_bug.cgi?id=27916

This revision was automatically updated to reflect the committed changes.