This is an archive of the discontinued LLVM Phabricator instance.

[Clang-tidy] Improve checks documentation consistency
ClosedPublic

Authored by Eugene.Zelenko on Apr 1 2016, 4:21 PM.

Details

Summary

I tried to make using of ` and more consistent. Two Google checks changed to aliases.

I'm not sure about using :option: for check options.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko retitled this revision from to [Clang-tidy] Improve checks documentation consistency.
Eugene.Zelenko updated this object.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: cfe-commits.
alexfh accepted this revision.Apr 1 2016, 6:00 PM
alexfh edited edge metadata.

Awesome! Thanks!

This revision is now accepted and ready to land.Apr 1 2016, 6:00 PM
alexfh added a comment.Apr 1 2016, 6:03 PM

Also, could you, please, next time generate diffs with full context as documented in http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface (or use arcanist, which does this automatically)? This sometimes (not in this case) saves reviewers manual work of finding the relevant source files and looking into them in order to see the context. Thanks!

Also, could you, please, next time generate diffs with full context as documented in http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface (or use arcanist, which does this automatically)? This sometimes (not in this case) saves reviewers manual work of finding the relevant source files and looking into them in order to see the context. Thanks!

I'll try to not forget next time :-)

This revision was automatically updated to reflect the committed changes.