This is an archive of the discontinued LLVM Phabricator instance.

Remove unsafe AssertZext after promoting result of FP_TO_FP16
ClosedPublic

Authored by pirama on Mar 23 2016, 7:23 PM.

Details

Summary

Some target lowerings of FP_TO_FP16, for instance ARM's vcvtb.f16.f32
instruction, do not guarantee that the top 16 bits are zeroed out.
Remove the unsafe AssertZext and add tests to exercise this.

Diff Detail

Event Timeline

pirama updated this revision to Diff 51506.Mar 23 2016, 7:23 PM
pirama retitled this revision from to Remove unsafe AssertZext after promoting result of FP_TO_FP16.
pirama updated this object.
pirama added subscribers: srhines, llvm-commits.
jmolloy accepted this revision.Mar 24 2016, 1:15 AM
jmolloy edited edge metadata.

Looks good and obvious to me. Thanks!

This revision is now accepted and ready to land.Mar 24 2016, 1:15 AM
This revision was automatically updated to reflect the committed changes.

Thanks James!