This is an archive of the discontinued LLVM Phabricator instance.

[lto] Avoid duplicate symbol error for appending linkage.
ClosedPublic

Authored by silvas on Mar 8 2016, 5:09 PM.

Details

Summary

I'm not sure if this is the right solution, since it seems like we need
to do something more with @llvm.global_ctors in
SymbolTable.cpp:addBitcodeFile.

Any ideas?

Diff Detail

Event Timeline

silvas updated this revision to Diff 50091.Mar 8 2016, 5:09 PM
silvas retitled this revision from to [lto] Avoid duplicate symbol error for appending linkage..
silvas updated this object.
silvas added a reviewer: rafael.
silvas added subscribers: llvm-commits, Bigcheese.
rafael edited edge metadata.Mar 8 2016, 5:22 PM
rafael added a subscriber: rafael.

I think the check you want is

Symflags & object::BasicSymbolRef::SF_FormatSpecific

Cheers,
Rafael

silvas updated this revision to Diff 50096.Mar 8 2016, 5:50 PM
silvas edited edge metadata.

Update for Rafael's suggestion.

ruiu added a subscriber: ruiu.Mar 8 2016, 5:52 PM
ruiu added inline comments.
ELF/InputFiles.cpp
449

We have "using namespace llvm::object" at beginning of this file.

silvas updated this revision to Diff 50099.Mar 8 2016, 6:09 PM

Update for Rui's comment.

silvas added a comment.Mar 8 2016, 6:09 PM

Also fixed the if above in r262983.

ELF/InputFiles.cpp
449

Fixed the if above in r262983.

This revision was automatically updated to reflect the committed changes.