[Clang-tidy] Make readability-container-size-empty working with STL string

[Eugene.Zelenko]

Summary

While working with LLDB code I noticed that readability-container-size-empty doesn't detect problems with STL string, so this my attempt to fix problem.

Build and regressions were OK on RHEL 6.

[dblaikie]

should probably have test coverage

[aaron.ballman]

I agree with David, I'd like to see test coverage for this (with both std::string and std::wstring to be paranoid).

[Eugene.Zelenko]

Also I agree that testing is good idea, it doesn't make sense in current incarnation which test only vector and set and only with containers' code snippets instead of real implementations. I wrote about last issue in cfe-dev, but idea was rejected.

Other issue is how to avoid code duplication for test conditions. Probably tests should be generated from templates for each container or should contain container definition and include shared test body.

[alexfh]

In D17434#356765, @dblaikie wrote:

should probably have test coverage

+1

clang-tidy/readability/ContainerSizeEmptyCheck.cpp

 
 static bool isContainerName(llvm::StringRef ClassName) {
   static const char *const ContainerNames[] = {"array",
+                                               "basic_string",
                                                "deque",
                                                "forward_list",
                                                "list",