This is an archive of the discontinued LLVM Phabricator instance.

Turn off lldb debug tuning by default for FreeBSD
ClosedPublic

Authored by dim on Jan 7 2016, 1:44 PM.

Details

Summary

This is the clang part of D15966. In rL256104, debugger tuning was
added to the clang driver, and again the default for FreeBSD was set to
lldb. The default needs to be gdb instead.

Diff Detail

Event Timeline

dim updated this revision to Diff 44252.Jan 7 2016, 1:44 PM
dim retitled this revision from to Turn off lldb debug tuning by default for FreeBSD.
dim updated this object.
dim added reviewers: emaste, probinson.
dim added a subscriber: cfe-commits.
emaste accepted this revision.Jan 7 2016, 1:51 PM
emaste edited edge metadata.

I advocated for the lldb tuning by default on FreeBSD originally, but I didn't fully understand the implications. It turns out we're just not ready yet. So, LGTM.

This revision is now accepted and ready to land.Jan 7 2016, 1:51 PM
probinson edited edge metadata.Jan 7 2016, 1:56 PM

Sure, I was just making it the same as LLVM's default.
Now that it's wired up through clang, people who want LLDB can use -glldb to get the same effect.

dim closed this revision.Jan 7 2016, 2:13 PM
emaste added a comment.Jan 7 2016, 2:18 PM

Sure, I was just making it the same as LLVM's default.

Yeah, the defaults ought to be the same; it turns out this change was just premature.