Page MenuHomePhabricator

Turn off lldb debug tuning by default for FreeBSD
ClosedPublic

Authored by dim on Jan 7 2016, 1:42 PM.

Details

Summary

In rL242338, debugger tuning was introduced, and the tuning for FreeBSD
was set to lldb by default. However, for the foreseeable future we
still need to default to gdb tuning, since lldb is not ready for all of
FreeBSD's architectures, and some system tools (like objcopy, etc) have
not yet been adapted to cope with the lldb tuned format, which has
.apple sections.

Therefore, let FreeBSD use gdb by default for now.

Diff Detail

Repository
rL LLVM

Event Timeline

dim updated this revision to Diff 44251.Jan 7 2016, 1:42 PM
dim retitled this revision from to Turn off lldb debug tuning by default for FreeBSD.
dim updated this object.
dim added reviewers: emaste, probinson.
dim added a subscriber: llvm-commits.
emaste accepted this revision.Jan 7 2016, 1:50 PM
emaste edited edge metadata.

I advocated for the lldb tuning by default on FreeBSD originally, but I didn't fully understand the implications. It turns out we're just not ready yet. So, LGTM.

This revision is now accepted and ready to land.Jan 7 2016, 1:50 PM
probinson edited edge metadata.Jan 7 2016, 1:54 PM

LGTM. Somebody had actually asked for the default to be LLDB, originally, but I'm not invested which way the default goes.

dim closed this revision.Jan 7 2016, 2:12 PM
This revision was automatically updated to reflect the committed changes.
emaste added a comment.Jan 7 2016, 2:20 PM

Somebody had actually asked for the default to be LLDB, originally

That was me. I didn't quite understand what was going to change though and subsequently realized there's more work we'll need to do in gdb, and other build tools before we can set this default on FreeBSD.