[clangd] Add hexadecimal member offsets and sizes to hover popup

[tetraxile]

Summary

This changes the formatting of class/struct member variable byte offsets and sizes, as well as class sizes, from just the decimal value, e.g. "Offset: 12 bytes", to both decimal and hexadecimal, e.g. "Offset: 12 (0xc) bytes".

I'm open to adding a config file option to disable this feature if users want to reduce clutter, but I think it'd be unnecessary, as the other lines in the hover popup (declaration, type, comment) are already quite a bit longer than the offset and size lines.

[SR_team]

Until a 10, we don't have difference between DEC and HEX, may be print only DEC in these cases?

[tetraxile]

Thanks for the suggestion SR_team, I've just added that.

[tetraxile]

Just bumping this patch, I'd like if it could get reviewed before Phabricator becomes read-only.

[tetraxile]

bumping again

clang-tools-extra/clangd/Hover.cpp

std::optional<HoverInfo> getHover(ParsedAST &AST, Position Pos,
 
   return HI;
 }
 
 // Sizes (and padding) are shown in bytes if possible, otherwise in bits.
 static std::string formatSize(uint64_t SizeInBits) {
   uint64_t Value = SizeInBits % 8 == 0 ? SizeInBits / 8 : SizeInBits;
   const char *Unit = Value != 0 && Value == SizeInBits ? "bit" : "byte";
-  return llvm::formatv("{0} ({0:x}) {1}{2}", Value, Unit, Value == 1 ? "" : "s")
-      .str();
+  const char *Fmt = Value >= 10 ? "{0} ({0:x}) {1}{2}" : "{0} {1}{2}";
+  return llvm::formatv(Fmt, Value, Unit, Value == 1 ? "" : "s").str();
 }
 
 // Offsets are shown in bytes + bits, so offsets of different fields
 // can always be easily compared.
 static std::string formatOffset(uint64_t OffsetInBits) {
   const auto Bytes = OffsetInBits / 8;
   const auto Bits = OffsetInBits % 8;
   auto Offset = formatSize(Bytes * 8);

clang-tools-extra/clangd/unittests/HoverTests.cpp

template <typename T, typename C = bool> class Foo {})",
             HI.Offset = 96;
             HI.Padding = 32;
           },
           R"(field foo
 
 Type: type (aka can_type)
 Value = value
 Offset: 12 (0xc) bytes
-Size: 4 (0x4) bytes (+4 (0x4) bytes padding)
+Size: 4 bytes (+4 bytes padding)
 
 // In test::Bar
 def)",
       },
       {
           [](HoverInfo &HI) {
             HI.Kind = index::SymbolKind::Field;
             HI.LocalScope = "test::Bar::";
             HI.Value = "value";
             HI.Name = "foo";
             HI.Type = {"type", "can_type"};
             HI.Definition = "def";
             HI.Size = 25;
             HI.Offset = 35;
             HI.Padding = 4;
           },
           R"(field foo
 
 Type: type (aka can_type)
 Value = value
-Offset: 4 (0x4) bytes and 3 (0x3) bits
-Size: 25 (0x19) bits (+4 (0x4) bits padding)
+Offset: 4 bytes and 3 bits
+Size: 25 (0x19) bits (+4 bits padding)
 
 // In test::Bar
 def)",
       },
       {
           [](HoverInfo &HI) {
             HI.Kind = index::SymbolKind::Field;
             HI.AccessSpecifier = "public";