[LIT] Add the –run-under parameter to lit, which lit.cfg will then use.

[mcrosier]

Summary

This functionality already exists within the make infrastructure in the form of several environment variables, but does not exist in the cmake infrastructure at present.

[MatzeB]

This patch has no context, and the code seems to just pass along a configuration option, doesn't it?

[rnk]

Agreed, what is the actual use case? Running with a dynamic tool like valgrind? Adding LD_PRELOAD? Remote test execution? Remotely executing tests that were cross-compiled?

[MatzeB]

In D15160#300727, @MatzeB wrote:

This patch has no context, and the code seems to just pass along a configuration option, doesn't it?

Oh I just realize that this is probably meant for the test-suite lit stuff.

It feels a bit weird to add parameters to main lit that are not used anywhere inside llvm. Do you expect this to be used often or would using something like "lit -DRUN_UNDER=xxx" which already exists be enough?

For the remote running stuff that I just pushed in test-suite r254545 I decided to configure things through lit.site.cfg and have the configuration options in cmake. This works nicely if the way you build things is somewhat tied to how you execute them which is the case for my typical cases where you cross compile to a device and execute remotely there. Maybe your use case is similar?

[mcrosier]

In D15160#300754, @MatzeB wrote:

In D15160#300727, @MatzeB wrote:

For the remote running stuff that I just pushed in test-suite r254545 I decided to configure things through lit.site.cfg and have the configuration options in cmake. This works nicely if the way you build things is somewhat tied to how you execute them which is the case for my typical cases where you cross compile to a device and execute remotely there. Maybe your use case is similar?

Your commit of r254545 does exactly what I was looking for! Thanks, Matthias.

utils/lit/lit/LitConfig.py

 
     def __init__(self, progname, path, quiet,
                  useValgrind, valgrindLeakCheck, valgrindArgs,
-                 noExecute, debug, isWindows,
+                 noExecute, runUnder, debug, isWindows,
                  params, config_prefix = None):
         # The name of the test runner.
         self.progname = progname

         self.valgrindLeakCheck = bool(valgrindLeakCheck)
         self.valgrindUserArgs = list(valgrindArgs)
         self.noExecute = noExecute
+        self.runUnder = runUnder
         self.debug = debug
         self.isWindows = bool(isWindows)
         self.params = dict(params)

utils/lit/lit/main.py

     group.add_option("", "--xunit-xml-output", dest="xunit_output_file",
                       help=("Write XUnit-compatible XML test reports to the"
                             " specified file"), default=None)
+    group.add_option("", "--run-under", dest="run_under", help=("Wrap test"
+                     " execution within specified command"),
+                    default=None)
     parser.add_option_group(group)
 
     group = OptionGroup(parser, "Test Selection")

         valgrindLeakCheck = opts.valgrindLeakCheck,
         valgrindArgs = opts.valgrindArgs,
         noExecute = opts.noExecute,
+        runUnder = opts.run_under,
         debug = opts.debug,
         isWindows = isWindows,
         params = userParams,