This is an archive of the discontinued LLVM Phabricator instance.

Regen some old tests; NFC
AbandonedPublic

Authored by goldstein.w.n on Apr 29 2023, 2:41 PM.

Details

Summary

Just so we can make future changes with update_llc_test_checks.py

Diff Detail

Event Timeline

goldstein.w.n created this revision.Apr 29 2023, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 2:41 PM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Apr 29 2023, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2023, 2:41 PM
RKSimon added inline comments.May 1 2023, 2:48 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
1–4

These need cleaning up - duplicate RUN, and I think you can have a common CHECK prefix as well

; RUN: llc < %s -mtriple=arm-apple-darwin | FileCheck %s --check-prefixes=CHECK,V7
; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s --check-prefixes=CHECK,V8
118–119

remove these

goldstein.w.n marked 2 inline comments as done.May 12 2023, 10:08 PM

Rebase + put before isKnownNonZero patch

RKSimon added inline comments.May 13 2023, 3:04 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
8

Where has the V7 coverage gone?

goldstein.w.n added inline comments.May 13 2023, 10:38 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
8

Where has the V7 coverage gone?

I think there is a bug somewhere. -mtriple=arm-apple-darwin simply does not generate automatic checks. Guess drop this one from regen and update it by hand in the known-non-zero patch?

RKSimon added inline comments.May 13 2023, 11:39 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
8

Sure, or update it manually here (remove the extra RUN etc.) - as long as you remove the NOTE from the top then it should be fine.

craig.topper added inline comments.May 15 2023, 5:05 PM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
8

I wonder if the triple should be armv7-apple-darwin which has an override in get_run_handler llvm/utils/UpdateTestChecks/asm.py. That override defines the regular expression to convert between IR function name and assembly function name.

RKSimon added inline comments.May 16 2023, 6:37 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
8

Probably - in which case we need to add the original arm-apple-darwin RUN line back again to retain coverage and we still can't auto generate it :)

RKSimon added a subscriber: dmgreen.
RKSimon added inline comments.
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
1–4

There's nothing darwin specific - so I think using this should be fine:

; RUN: llc < %s -mtriple=arm-none | FileCheck %s
; RUN: llc < %s -mtriple=armv7-none-linux-gnueabi | FileCheck %s --check-prefixes=V78,V7
; RUN: llc < %s -mtriple=armv8-none-linux-gnueabi | FileCheck %s -check-prefixes=V78,V8

@dmgreen Any comments?

dmgreen added inline comments.May 17 2023, 4:45 AM
llvm/test/CodeGen/ARM/sub-cmp-peephole.ll
1–4

Yeah, that sounds OK to me.

goldstein.w.n marked 2 inline comments as done.

Update target so tests autogen

dmgreen accepted this revision.May 18 2023, 12:08 AM

Thanks. LGTM

This revision is now accepted and ready to land.May 18 2023, 12:08 AM
RKSimon accepted this revision.May 18 2023, 2:17 AM

LGTM cheers

goldstein.w.n abandoned this revision.Jul 9 2023, 4:48 PM

Since the motivating patch was abandoned, abandoning this.