Centos 5 compile fixes for lldb

[mchandler-blizzard]

Summary

Adds checks for posix features not present in centos 5

[labath]

Thanks for the patch. Looks good, but we need to make sure things continue to work on non-linux systems...

tools/lldb/source/Host/common/File.cpp

301

This needs to evaluate to true on non-linux systems.
Would #ifdef O_CLOEXEC work for you ?

[krytarowski]

tools/lldb/source/Host/common/File.cpp

301

NetBSD:

/usr/include/fcntl.h:#define	O_CLOEXEC	0x00400000	/* set close on exec */

[krytarowski]

tools/lldb/source/Host/posix/PipePosix.cpp

32

Is this file just for Linux?

254

Stop breaking NetBSD.

[brucem]

tools/lldb/source/Host/linux/HostThreadLinux.cpp

33

This is probably better done with weak symbols or a check in configure and cmake rather than hard-coding this stuff in the C pre-processor.

tools/lldb/source/Host/posix/PipePosix.cpp

32

This file isn't Linux only, so the concerns expressed by Labath are valid here as well. (The same thing is true of other inclusions of <linux/version.h>.)

tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

72

This bug was fixed in 2007, over 8 years ago ... at what point do we stop carrying around this baggage?

[krytarowski]

tools/lldb/source/Host/posix/PipePosix.cpp

43

How about moving PIPE2_SUPPORTED to include/lldb/Host/*/Config.h? It could be renamed to LLDB_CONFIG_PIPE2_SUPPORTED. Feel free to include in the Linux configuration headers needed to detect Linux version.

[krytarowski]

tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

72

Few defines aren't much of entanglement. RHEL5 is still supported upstream (till 2017).

https://en.wikipedia.org/wiki/Red_Hat_Enterprise_Linux#Product_life_cycle

[mchandler-blizzard]

tools/lldb/source/Host/common/File.cpp

301

If that is ok by the coding standards im happy to change it to that

tools/lldb/source/Host/linux/HostThreadLinux.cpp

33

If you want to provide code that does that, im happy to change it.

tools/lldb/source/Host/posix/PipePosix.cpp

32

I dont have other OS's to build on so not sure. Think @krytarowski comment below is the way to go.

254

:(

[emaste]

For future diffs please include additional context (e.g. git diff -U99999)

[krytarowski]

This patch looks dead -- no activity.

tools/lldb/include/lldb/Host/linux/Signalfd.h

 #ifndef liblldb_Host_linux_Signalfd_h_
 #define liblldb_Host_linux_Signalfd_h_
 
+#include <linux/version.h>
+
 #ifdef __ANDROID_NDK__
 #include <android/api-level.h>
 #endif
 
-#if defined(__ANDROID_API__) && __ANDROID_API__ < 21
+#if (defined(__ANDROID_API__) && __ANDROID_API__ < 21) || (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26))
 
 #include <linux/types.h>
+
+#if defined(__ANDROID_API__) && __ANDROID_API__ < 21
 #include <linux/fcntl.h>
+#else
+#include <fcntl.h>
+#endif
 
 #define SFD_CLOEXEC O_CLOEXEC
 #define SFD_NONBLOCK O_NONBLOCK

tools/lldb/source/Host/common/File.cpp

 #include "lldb/Host/windows/windows.h"
 #else
 #include <sys/ioctl.h>
+#include <linux/version.h>
 #endif
 
 #include "llvm/Support/Process.h" // for llvm::sys::Process::FileDescriptorHasColors()

 #ifndef _WIN32
     if (options & eOpenOptionNonBlocking)
         oflag |= O_NONBLOCK;
+    
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
     if (options & eOpenOptionCloseOnExec)
         oflag |= O_CLOEXEC;
+#endif
 #else
     oflag |= O_BINARY;
 #endif

         error.SetErrorToErrno();
     else
     {
+#ifndef _WIN32
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23)
+    if (options & eOpenOptionCloseOnExec)
+    {
+        int oldFlags = fcntl(m_descriptor, F_GETFD, 0);
+        fcntl(m_descriptor, F_SETFD, FD_CLOEXEC|oldFlags);
+    }
+#endif
+#endif
         m_should_close_fd = true;
         m_options = options;
     }

tools/lldb/source/Host/linux/HostThreadLinux.cpp

 void
 HostThreadLinux::SetName(lldb::thread_t thread, llvm::StringRef name)
 {
-#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__)
+#if (defined(__GLIBC__) && defined(_GNU_SOURCE) && __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 12) || defined(__ANDROID__)
     ::pthread_setname_np(thread, name.data());
 #else
     (void) thread;

tools/lldb/source/Host/posix/PipePosix.cpp

 #include <sys/types.h>
 #include <sys/stat.h>
 
+#include <linux/version.h>
+
 using namespace lldb;
 using namespace lldb_private;
 

 
 // pipe2 is supported by a limited set of platforms
 // TODO: Add more platforms that support pipe2.
-#if defined(__linux__) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
+#if (defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,27)) || (defined(__FreeBSD__) && __FreeBSD__ >= 10) || defined(__NetBSD__)
 #define PIPE2_SUPPORTED 1
 #else
 #define PIPE2_SUPPORTED 0

         return Error("Pipe is already opened");
 
     int flags = O_RDONLY | O_NONBLOCK;
+    
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
     if (!child_process_inherit)
         flags |= O_CLOEXEC;
+#endif
 
     Error error;
     int fd = ::open(name.data(), flags);
     if (fd != -1)
+    {
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23)
+        if (!child_process_inherit)
+        {
+            int oldFlags = fcntl(fd, F_GETFD, 0);
+            fcntl(fd, F_SETFD, FD_CLOEXEC|oldFlags);
+        }
+#endif
         m_fds[READ] = fd;
+    }
     else
         error.SetErrorToErrno();
 

         return Error("Pipe is already opened");
 
     int flags = O_WRONLY | O_NONBLOCK;
+    
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
     if (!child_process_inherit)
         flags |= O_CLOEXEC;
+#endif
 
     using namespace std::chrono;
     const auto finish_time = Now() + timeout;

         }
         else
         {
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23)
+            if (!child_process_inherit)
+            {
+                int oldFlags = fcntl(fd, F_GETFD, 0);
+                fcntl(fd, F_SETFD, FD_CLOEXEC|oldFlags);
+            }
+#endif
             m_fds[WRITE] = fd;
         }
     }

tools/lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

   #define TRAP_HWBKPT 4
 #endif
 
+// Missing defines due to bug: https://sourceware.org/bugzilla/show_bug.cgi?id=4125
+
+#if !HAVE_DECL_ADDR_NO_RANDOMIZE
+  #define ADDR_NO_RANDOMIZE 0x0040000
+#endif
+
+#ifndef PTRACE_O_TRACECLONE
+  #define PTRACE_O_TRACECLONE    0x00000008
+#endif
+
+#ifndef PTRACE_O_TRACEEXEC
+  #define PTRACE_O_TRACEEXEC     0x00000010
+#endif
+
+#ifndef PTRACE_O_TRACEEXIT
+  #define PTRACE_O_TRACEEXIT     0x00000040
+#endif
+
+#ifndef PTRACE_EVENT_CLONE
+  #define PTRACE_EVENT_CLONE     3
+#endif
+
+#ifndef PTRACE_EVENT_EXEC
+  #define PTRACE_EVENT_EXEC      4
+#endif
+
+#ifndef PTRACE_EVENT_EXIT
+  #define PTRACE_EVENT_EXIT      6
+#endif
+
 using namespace lldb;
 using namespace lldb_private;
 using namespace lldb_private::process_linux;

tools/lldb/source/Target/ProcessLaunchInfo.cpp

 
 #if !defined(_WIN32)
 #include <limits.h>
+
+#include <linux/version.h>
 #endif
 
 using namespace lldb;

                                  __FUNCTION__);
 
                 int open_flags = O_RDWR | O_NOCTTY;
-#if !defined(_MSC_VER)
+#if !defined(_MSC_VER) && LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
                 // We really shouldn't be specifying platform specific flags
                 // that are intended for a system call in generic code.  But
                 // this will have to do for now.

tools/lldb/source/Utility/PseudoTerminal.cpp

 
 pid_t fork(void) { return 0; }
 pid_t setsid(void) { return 0; }
+
+#include <linux/version.h>
 #elif defined(__ANDROID_NDK__)
 #include "lldb/Host/android/Android.h"
 int posix_openpt(int flags);

     pid_t pid = LLDB_INVALID_PROCESS_ID;
 #if !defined(LLDB_DISABLE_POSIX)
     int flags = O_RDWR;
+
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
     flags |= O_CLOEXEC;
+#endif
     if (OpenFirstAvailableMaster (flags, error_str, error_len))
     {
         // Successfully opened our master pseudo terminal