Page MenuHomePhabricator

Rename argdumper to lldb-argdumper.
ClosedPublic

Authored by tfiala on Oct 28 2015, 6:14 PM.

Details

Summary

Distributions that put lldb binaries in /usr/bin and whatnot are going to put argdumper in the same place. argdumper is way too generic a name. Rename to lldb-argdumper, to match our lldb- prefix for lldb executables.

This change fixes the Xcode and cmake builds to use lldb-argdumper as the binary name.

I've tested this patch on OS X 10.11 and Ubuntu 14.04 x86_64.

I will make follow-up changes (after verifying the name change works) to:

  • eliminate the dependence on liblldb - that is silly for this binary.
  • rename the directory and source file names to match lldb-argdumper.

I'd rather break this into an end-product change (this one) and the file/directory naming change rather than jam those together.

Diff Detail

Event Timeline

tfiala updated this revision to Diff 38704.Oct 28 2015, 6:14 PM
tfiala retitled this revision from to Rename argdumper to lldb-argdumper..
tfiala updated this object.
tfiala added reviewers: labath, zturner, jasonmolenda.
tfiala added a subscriber: lldb-commits.
labath accepted this revision.Oct 28 2015, 6:26 PM
labath edited edge metadata.

Looks good.

argdumper should probably go to /usr/libexec, but then I guess we won't be able to find it, so that's a different story...

This revision is now accepted and ready to land.Oct 28 2015, 6:26 PM

Looks good.

argdumper should probably go to /usr/libexec, but then I guess we won't be able to find it, so that's a different story...

Exactly right. That will require more work.

scripts/Python/finish-swig-Python-LLDB.sh

Hmm I think there is a python implementation of this script that I may have missed. Checking on that now.

scripts/Python/finish-swig-Python-LLDB.sh

Hmm I think there is a python implementation of this script that I may have missed. Checking on that now.

Yes there is. I need to adjust one other place. I'll update the patch.

tfiala updated this revision to Diff 38715.Oct 28 2015, 10:02 PM
tfiala edited edge metadata.

Fixed up one missed spot, the python-based class completion script.

I think the original clean build and test run on Linux missed this because I don't think we actually use it on Linux. It's primarily useful on OS X 10.11 and beyond where we cannot launch inferiors through the shell any longer with System Integrity Protection.

In any event, the latest patch fixes up the symbolic link creation within the python module directory on non-OS X systems.

I'm out the next couple days at the LLVM conference. I'm going to put this in. We'll revert it out if it causes any trouble on Windows and fix it up.

tfiala closed this revision.Oct 28 2015, 10:13 PM

Closed by commit:

$ svn commit
Sending        lldb.xcodeproj/project.pbxproj
Sending        scripts/Python/finish-swig-Python-LLDB.sh
Sending        scripts/Python/finishSwigPythonLLDB.py
Sending        source/Host/macosx/Host.mm
Sending        source/Host/windows/Host.cpp
Sending        tools/argdumper/CMakeLists.txt
Transmitting file data ......
Committed revision 251616.