Page MenuHomePhabricator

[LLDB] Attempt to fix MSVC builds after rL250966
ClosedPublic

Authored by Eugene.Zelenko on Oct 21 2015, 6:24 PM.

Details

Summary

Looks like MSVC build failure didn't relate to my changes, since I didn't remove lldb/Expression/UtilityFunction.h from any of files changed in rL250966. May be source/Plugins/LanguageRuntime was not properly rebuilt after other change?

Event Timeline

Eugene.Zelenko retitled this revision from to [LLDB] Attempt to fix MSVC builds after rL250966.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: lldb-commits.
zturner accepted this revision.Oct 21 2015, 7:04 PM
zturner edited edge metadata.

lgtm. In the future you don't need to ask for a review to unbreak a build.

This revision is now accepted and ready to land.Oct 21 2015, 7:04 PM

If this fixes the windows build, can you please commit it ASAP?

I would have done this last night but I didn't have a machine handy. I'll
test it out now and commit if it fixes. And yea, in the future please just
commit fixes.

clayborg accepted this revision.Oct 22 2015, 9:47 AM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.