This is an archive of the discontinued LLVM Phabricator instance.

[PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs
ClosedPublic

Authored by davidxl on Sep 30 2015, 10:46 PM.

Details

Summary

Driver toolchain refactoring to allow easy command line overriding in the future.

Diff Detail

Event Timeline

davidxl updated this revision to Diff 36185.Sep 30 2015, 10:46 PM
davidxl retitled this revision from to [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes).
davidxl updated this object.
davidxl added reviewers: rsmith, bogner.
davidxl added a subscriber: cfe-commits.
davidxl updated this revision to Diff 36186.Sep 30 2015, 10:50 PM
davidxl removed subscribers: tberghammer, danalbert, srhines.
davidxl updated this revision to Diff 36190.Sep 30 2015, 11:08 PM

fix broken test (by clang-format).

davidxl updated this revision to Diff 36316.Oct 1 2015, 3:43 PM

I have modified the implementation to not use linker script, so this clang patch becomes strictly refactoring with NFC. I think it is still a good thing to have this in so that similar tunings like this can be done in the future.

davidxl abandoned this revision.Oct 13 2015, 12:10 PM

The refactoring is done by a previous patch already.

davidxl retitled this revision from [PGO]: Eliminate __llvm_profile_register calls for Linux (clang changes) to [PGO]: ToolChain class refactoring: move addProfileRT to be a virtal method: ToolChain::addProfileRTLibs.Oct 21 2015, 9:53 PM
davidxl updated this object.

It turns out previous refactoring by another commit only covers half of the work.

Will update the patch with Justin's comments and commit after testing.

davidxl updated this revision to Diff 38091.Oct 21 2015, 11:15 PM

Updated patch.

This revision was automatically updated to reflect the committed changes.