This is an archive of the discontinued LLVM Phabricator instance.

Make the ArmUnwindInfo parsing code endian independent
ClosedPublic

Authored by tberghammer on Sep 30 2015, 7:51 AM.

Diff Detail

Event Timeline

tberghammer retitled this revision from to Make the ArmUnwindInfo parsing code endian independent.
tberghammer updated this object.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
labath accepted this revision.Sep 30 2015, 8:07 AM
labath edited edge metadata.

Looks good, after fixing some typos.

include/lldb/Symbol/ArmUnwindInfo.h
55

For consideration:
storing just the byte order instead of the whole ObjectFile. (if it's clear that the ObjectFile object outlives this object then I'm fine with this also).

source/Symbol/ArmUnwindInfo.cpp
58

s/Custome/Custom/
s/red/read/

66

s/data[0]/value ?

This revision is now accepted and ready to land.Sep 30 2015, 8:07 AM
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.