This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] [asan] Enable DFSan for AArch64/42-bit VMA
ClosedPublic

Authored by zatrazz on Aug 21 2015, 6:38 AM.

Details

Summary

This patch adds support for dfsan on aarch64-linux with 42-bit VMA
(current default config for 64K pagesize kernels). The support is
enabled by defining the SANITIZER_AARCH64_VMA to 42 at build time
for both clang/llvm and compiler-rt. The default VMA is 39 bits.

Diff Detail

Event Timeline

zatrazz updated this revision to Diff 32823.Aug 21 2015, 6:38 AM
zatrazz retitled this revision from to [compiler-rt] [asan] Enable DFSan for AArch64/42-bit VMA.
zatrazz updated this object.
zatrazz added reviewers: rengolin, kcc, eugenis, dvyukov.
zatrazz added a subscriber: llvm-commits.
rengolin added inline comments.Aug 21 2015, 10:14 AM
lib/dfsan/dfsan.cc
132

This looks wrong with the table above?

zatrazz added inline comments.Aug 21 2015, 10:24 AM
lib/dfsan/dfsan.cc
132

In fact is the contraty, the comment needs update. I'll change it.

rengolin added inline comments.Aug 21 2015, 11:29 AM
lib/dfsan/dfsan.h
52

Do you need the same trick with defining it to 39 when undef? Or is this getting from the same header as the other sans?

The SANITIZER_AARCH64_VMA is defined in a common header (lib/sanitizer_common/sanitizer_platform.h) used by all sanitizers.

rengolin accepted this revision.Aug 21 2015, 1:55 PM
rengolin edited edge metadata.

LGTM after updating the comment. Thanks!

lib/dfsan/dfsan.cc
132

makes sense, this is 3 bits to the left. :)

This revision is now accepted and ready to land.Aug 21 2015, 1:55 PM
zatrazz closed this revision.Aug 25 2015, 5:41 AM