This is an archive of the discontinued LLVM Phabricator instance.

[regalloc] Remove -consider-local-interval-cost
ClosedPublic

Authored by mtrofin on Mar 7 2022, 8:30 AM.

Details

Summary

Discussed extensively on D98232. The functionality introduced in D35816
never worked correctly. In D98232, it was fixed, but, as it was
introducing a large compile-time regression, and the value of the
original patch was called into doubt, we disabled it by default
everywhere. A year later, it appears that caused no grief, so it seems
safe to remove the disabled code.

This should be accompanied by re-opening bug 26810.

Diff Detail

Event Timeline

mtrofin created this revision.Mar 7 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 8:30 AM
mtrofin requested review of this revision.Mar 7 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 8:30 AM
nikic accepted this revision.Mar 7 2022, 8:46 AM

LGTM

This revision is now accepted and ready to land.Mar 7 2022, 8:46 AM
This revision was landed with ongoing or failed builds.Mar 14 2022, 10:49 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll