This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget][AMDGCN] add gfx90c target
ClosedPublic

Authored by ye-luo on Feb 10 2022, 1:16 PM.

Diff Detail

Event Timeline

ye-luo created this revision.Feb 10 2022, 1:16 PM
ye-luo requested review of this revision.Feb 10 2022, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 1:16 PM
ye-luo added a comment.EditedFeb 10 2022, 1:19 PM

ROCm 5.0.0 requires me to use this target on my 4700u

JonChesterfield accepted this revision.EditedFeb 10 2022, 1:30 PM
JonChesterfield added a subscriber: arsenm.

That's somewhat interesting, @arsenm the 4000 series APUs used to identify as gfx902 iirc - does the new name for existing hardware make sense to you?

90c introduced in https://reviews.llvm.org/D90419, only change I can see in that a change to sramecc, which I thought was a targetid thing and not an isa thing. It does name various APUs as now corresponding to 90c though. So this change is fine.

This revision is now accepted and ready to land.Feb 10 2022, 1:30 PM

I was using gfx902 in the past but after installing ROCm 5.0.0 today, I got a complaint and I have to use gfx90c by copying gfx902 bc files to gfx90c.
However it is better to do the right thing here.

This revision was automatically updated to reflect the committed changes.