Details
- Reviewers
emaste zturner jingham brucem loladiro - Commits
- rGec3af0f94e5e: Bug 24332 - Fix the build of lldb under GNU/Linux when using autotools
rLLDB244039: Bug 24332 - Fix the build of lldb under GNU/Linux when using autotools
rL244039: Bug 24332 - Fix the build of lldb under GNU/Linux when using autotools
Diff Detail
Event Timeline
I don't have the authority to approve something to be committed afaik, but hopefully my comments here are useful.
source/Plugins/Makefile | ||
---|---|---|
46 | I'm not an expert in the autotools build system, but it seems likely that the ScriptInterpreters could be added to the global list of them rather than the per-OS ones. (This differs from what I wrote in the bug probably.) It might be worth checking with Keno Fischer as well as he likes to have a build that doesn't use Python and he might have some feedback on this. | |
52 | As above. |
Zachary, do you agree with Bruce? (that the change should be for every platform, not Darwin/Linux specific)?
I did the change locally but didn't push yet.
Probably it should be at least for FreeBSD, but I don't know that anyone else uses the autoconf build, and my understanding is that it's going away kind of soon anyway.
I'm not an expert in the autotools build system, but it seems likely that the ScriptInterpreters could be added to the global list of them rather than the per-OS ones. (This differs from what I wrote in the bug probably.)
It might be worth checking with Keno Fischer as well as he likes to have a build that doesn't use Python and he might have some feedback on this.