This is an archive of the discontinued LLVM Phabricator instance.

[dfsan] Enable dfsan for aarch64
ClosedPublic

Authored by zatrazz on Jul 30 2015, 7:47 AM.

Details

Summary

This patch enable DFSan for AArch64 (39-bit VMA). All tests are passing
but:

  • test/dfsan/custom.cc

Due an invalid access in dl_iterate_phdr instrumentation (commenting out
this function make the testcase to pass). I plan to continue investigate this
issue.

lllvm related patch: http://reviews.llvm.org/D11646
clang related patch: http://reviews.llvm.org/D11645

Diff Detail

Event Timeline

zatrazz updated this revision to Diff 31026.Jul 30 2015, 7:47 AM
zatrazz retitled this revision from to [dfsan] Enable dfsan for aarch64.
zatrazz updated this object.
zatrazz added reviewers: kcc, rengolin, dvyukov, eugenis.
zatrazz added a subscriber: llvm-commits.
eugenis added a reviewer: pcc.Jul 30 2015, 9:50 AM
eugenis edited edge metadata.Jul 30 2015, 9:53 AM

Please upload patches with more context next time (see http://llvm.org/docs/Phabricator.html#id3).

The change looks OK but I'll leave it for Peter to approve.

Also, if a test still fails, adding aarch64 to the supported arch list will result in a failing bot.

pcc accepted this revision.Jul 30 2015, 11:22 AM
pcc edited edge metadata.

Please add an XFAIL for the failing test. Otherwise LGTM.

This revision is now accepted and ready to land.Jul 30 2015, 11:22 AM
zatrazz closed this revision.Jul 31 2015, 10:07 AM