This is an archive of the discontinued LLVM Phabricator instance.

COFF: Remove the old COFF linker and rename link2 link.
ClosedPublic

Authored by ruiu on Jul 29 2015, 2:20 PM.

Details

Summary

Now that the new COFF linker is complete, we can make the new
one as the default linker for "-flavor link".

Diff Detail

Event Timeline

ruiu updated this revision to Diff 30944.Jul 29 2015, 2:20 PM
ruiu retitled this revision from to COFF: Remove the old COFF linker and rename link2 link..
ruiu updated this object.
ruiu added reviewers: compnerd, rafael.
ruiu set the repository for this revision to rL LLVM.
ruiu added a subscriber: llvm-commits.
pcc added a subscriber: pcc.Jul 29 2015, 2:49 PM

You can probably also remove the stuff at the bottom of tools/lld/CMakeLists.txt now. There's also a trivial change to compiler-rt (s/lld-link2/lld-link/) that would need to happen at the same time.

ruiu updated this revision to Diff 30951.Jul 29 2015, 3:03 PM
ruiu removed rL LLVM as the repository for this revision.

On second thought, I think we should keep "-flavor link2" as an alias
to "-flavor link" for a short period of time until we fix other places that
uses "link2" instead of "link". This should be safer and less annoying.

In this updated patch, "-flavor link2" is handled as a synonym to
"-flavor link".

rafael accepted this revision.Aug 4 2015, 5:36 AM
rafael edited edge metadata.

This is awesome and fine by me! :-)

This revision is now accepted and ready to land.Aug 4 2015, 5:36 AM
ruiu added a comment.Aug 5 2015, 10:49 PM

Now that we get a basic level of ARM support, there's no road block for this patch.
I'll submit this soon.

After I submit this patch, "-flavor link" (or lld-link.exe) will become a synonym to
"-flavor link2" (or lld-link2.exe).

compnerd accepted this revision.Aug 5 2015, 10:53 PM
compnerd edited edge metadata.

Thanks for the help with getting the ARM support working.

Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r244226.

test/pecoff/weak-external.test