This will simplify Linaro's buildbot maintenance scripts.
Details
Diff Detail
- Repository
- rZORG LLVM Github Zorg
Event Timeline
LGTM
You should mention in the commit msg that this also removes the libcxx bot names, which moved to buildkite a while ago.
If you're using arc it doesn't update the description for you unfortunately. (I wish it did) You can "edit revision" and change it there, but either way the message that you push with is the one that ends up in the repo, the phab one is just for phab.
I have a couple of minor comments, overall looks good.
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
521–522 | Nitpick: Can we standardize on a suffix for 2-stage bots? With this we'd have '2stage' here, 'selfhost' for 'clang-armv7-selfhost[-neon]', 'sh' for 'clang-thumbv7-full-sh', and nothing for many of the aarch64 bots (e.g. c'clang-aarch64-full'). | |
1019–1020 | Nitpick: Why are we adding ubuntu to the lldb bot names and removing it from the flang bot names? |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
521–522 | Sorry, I missed this comment. I'll post a separate patch to standardize on "-2stage" suffix for 2-stage bots. | |
1019–1020 | All LLDB bots seem to consistently specify OS, while compiler bots don't. It kinda makes sense that debugger is more OS-dependent than a compiler/assembler/linker. |
Nitpick: Can we standardize on a suffix for 2-stage bots? With this we'd have '2stage' here, 'selfhost' for 'clang-armv7-selfhost[-neon]', 'sh' for 'clang-thumbv7-full-sh', and nothing for many of the aarch64 bots (e.g. c'clang-aarch64-full').