This is an archive of the discontinued LLVM Phabricator instance.

[zorg] Rename Linaro's AArch64 and ARM bots to use consistent names
ClosedPublic

Authored by maxim-kuvyrkov on Jun 9 2021, 5:22 AM.

Details

Summary

This will simplify Linaro's buildbot maintenance scripts.

Diff Detail

Event Timeline

maxim-kuvyrkov created this revision.Jun 9 2021, 5:22 AM
maxim-kuvyrkov requested review of this revision.Jun 9 2021, 5:22 AM
DavidSpickett added a subscriber: DavidSpickett.

LGTM

You should mention in the commit msg that this also removes the libcxx bot names, which moved to buildkite a while ago.

DavidSpickett accepted this revision.Jun 9 2021, 5:51 AM
This revision is now accepted and ready to land.Jun 9 2021, 5:51 AM

Update commit log message

If you're using arc it doesn't update the description for you unfortunately. (I wish it did) You can "edit revision" and change it there, but either way the message that you push with is the one that ends up in the repo, the phab one is just for phab.

rovka added a subscriber: rovka.Jun 10 2021, 1:01 AM

I have a couple of minor comments, overall looks good.

buildbot/osuosl/master/config/builders.py
521–522

Nitpick: Can we standardize on a suffix for 2-stage bots? With this we'd have '2stage' here, 'selfhost' for 'clang-armv7-selfhost[-neon]', 'sh' for 'clang-thumbv7-full-sh', and nothing for many of the aarch64 bots (e.g. c'clang-aarch64-full').

1019–1020

Nitpick: Why are we adding ubuntu to the lldb bot names and removing it from the flang bot names?

maxim-kuvyrkov added inline comments.Jun 15 2021, 9:58 AM
buildbot/osuosl/master/config/builders.py
521–522

Sorry, I missed this comment. I'll post a separate patch to standardize on "-2stage" suffix for 2-stage bots.

1019–1020

All LLDB bots seem to consistently specify OS, while compiler bots don't. It kinda makes sense that debugger is more OS-dependent than a compiler/assembler/linker.