This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in lib/Format
AbandonedPublic

Authored by LegalizeAdulthood on May 25 2015, 1:23 PM.

Details

Summary

Use clang-tidy to simplify boolean conditional return statements

Diff Detail

Event Timeline

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in lib/Format.
LegalizeAdulthood updated this object.
LegalizeAdulthood edited the test plan for this revision. (Show Details)
LegalizeAdulthood added a subscriber: Unknown Object (MLST).
djasper edited edge metadata.May 26 2015, 12:16 AM

This is not desirable. I guess you somehow need to figure out cases where a bunch of specific cases are checked falling back to a default. Merging one of those cases with the default is generally bad (I'd say).

djasper requested changes to this revision.Jun 23 2015, 4:52 AM
djasper edited edge metadata.
This revision now requires changes to proceed.Jun 23 2015, 4:52 AM
LegalizeAdulthood abandoned this revision.Jun 30 2015, 8:16 AM