Page MenuHomePhabricator

[AMDGPU] Check for all meta instrs in GCNRegBankReassign
ClosedPublic

Authored by rampitec on Thu, Apr 8, 1:29 PM.

Details

Summary

It used to work correctly even with a KILL, but there is
no reason to consider meta instructions since they do not
create real HW uses.

Diff Detail

Event Timeline

rampitec created this revision.Thu, Apr 8, 1:29 PM
rampitec requested review of this revision.Thu, Apr 8, 1:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 8, 1:29 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added a comment.Thu, Apr 8, 1:31 PM

If it doesn't make an observable difference, there's no real reason to add the extra check?

If it doesn't make an observable difference, there's no real reason to add the extra check?

There is a difference though. In the last test with KILL %1, %0 before the patch %1 would be reassigned to v3 since v1 and v5 have bank conflict. After the patch it will remain in v5 as assigned which leaves more room for other reassignments. This is a fake conflict. Plus we do not need to spend any time on the false coflicts.

arsenm accepted this revision.Thu, Apr 8, 1:37 PM
This revision is now accepted and ready to land.Thu, Apr 8, 1:37 PM
This revision was landed with ongoing or failed builds.Thu, Apr 8, 1:41 PM
This revision was automatically updated to reflect the committed changes.