This is an archive of the discontinued LLVM Phabricator instance.

[Hexagon, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 1 2021, 4:58 PM.

Details

Summary

LLVM test CodeGen/Hexagon/hwloop3.ll tries to check for the absence of a
sequence of consecutive instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit merges the two CHECK-NOT into a single CHECK-NOT that
matches the content of two successive non-blank lines, thereby allowing
to preserve the intent of the test.

Diff Detail

Event Timeline

thopre requested review of this revision.Apr 1 2021, 4:58 PM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 4:58 PM
bcahoon accepted this revision.Apr 2 2021, 7:32 AM
This revision is now accepted and ready to land.Apr 2 2021, 7:32 AM
This revision was automatically updated to reflect the committed changes.