Changed ResolveState to unsigned to work around noisy gcc warning

[vharron]

Summary

Fixes this warning:

warning: 'lldb_private::Type::Flags::clang_type_resolve_state' is too small to hold all values of 'lldb_private::Type::ResolveState {aka enum lldb_private::Type::ResolveStateTag}'

ResolveState    clang_type_resolve_state : 2;

This is because ResolveState is defined with a base type "unsigned",
which requires more than two bits of storage.

g++ enum.cpp -std=c++11

typedef enum ResolveStateTag : unsigned
{

eResolveStateUnresolved = 0,
eResolveStateForward    = 1,
eResolveStateLayout     = 2,
eResolveStateFull       = 3

} ResolveState;

struct foo
{

ResolveState rs : 2;

};

int main()
{

foo test;
test.rs = eResolveStateFull;

}

[vharron]

I will change this to only use "unsigned" type when compiled with gcc.

[clayborg]

Looks good.

[vharron]

238283

include/lldb/Symbol/Type.h

protected:
     Type *m_encoding_type;
     lldb::user_id_t m_encoding_uid;
     EncodingDataType m_encoding_uid_type;
     uint64_t m_byte_size;
     Declaration m_decl;
     ClangASTType m_clang_type;
     
     struct Flags {
-        ResolveState    clang_type_resolve_state : 2;
+        // clang_type_resolve_state is a ResolveState enum
+        // using unsigned type here to work around a very noisy gcc warning
+        unsigned        clang_type_resolve_state : 2;
         bool            is_complete_objc_class   : 1;
     } m_flags;
 
     Type *
     GetEncodingType ();
     
     bool 
     ResolveClangType (ResolveState clang_type_resolve_state);