This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Fix Error/assert.test regression with symbols
ClosedPublic

Authored by jankratochvil on Mar 28 2021, 12:27 AM.

Details

Summary
Failed Tests (1):
  lldb-shell :: Error/assert.test

LLDB on Linux built with symbols is showing this error. I was not bisecting when it happened (my buildbot builds without symbols) but I find the fix obvious.
Without symbols it still PASSes:

lldb-test: /home/jkratoch/redhat/llvm-monorepo/lldb/source/Utility/LLDBAssert.cpp:29: void lldb_private::lldb_assert(bool, const char *, const char *, const char *, unsigned int): Assertion `false && "lldb_assert failed"' failed.

With symbols it FAILs:

lldb-test: /home/jkratoch/redhat/llvm-monorepo/lldb/tools/lldb-test/lldb-test.cpp:1086: int opts::assert::lldb_assert(lldb_private::Debugger &): Assertion `false && "lldb-test assert"' failed.

For the symbols build using:

time cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Debug -DLLVM_USE_LINKER=lld -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_USE_SPLIT_DWARF=OFF -DCMAKE_CXX_FLAGS="-gsplit-dwarf=single" -DCMAKE_C_FLAGS="-gsplit-dwarf=single" -GNinja

Diff Detail

Event Timeline

jankratochvil requested review of this revision.Mar 28 2021, 12:27 AM
jankratochvil created this revision.
This revision is now accepted and ready to land.Mar 28 2021, 6:14 PM