Don't close handle returned by _get_osfhandle

[ovyalov]

Summary

Apparently, there is no need to close handle that is returned by _get_osfhandle - it should be closed anyway than original handle is closed.

[ovyalov]

Aidan, could you let me know whether this patch prevents lldb from crashing on Windows?

[ADodds]

Hi Oleksiy,

I tested your patch this morning and it does indeed fix the crash we have been seeing.
I still feel it would be nice to tie the LockFileWindows to the lifetime of the File object who's handle its using, but perhaps we can address that if the issue arises.

Thanks,
Aidan

[ovyalov]

In D9931#181690, @ADodds wrote:

Hi Oleksiy,

I tested your patch this morning and it does indeed fix the crash we have been seeing.
I still feel it would be nice to tie the LockFileWindows to the lifetime of the File object who's handle its using, but perhaps we can address that if the issue arises.

Thanks,
Aidan

Hi Aidan,

totally makes sense - with this CL I just wanted to fix an ongoing issue that you're facing.

Thank you.

[ovyalov]

AFFECTED FILES

/lldb/trunk/source/Host/windows/LockFileWindows.cpp

USERS

ovyalov (Author)

http://reviews.llvm.org/rL238770

source/Host/windows/LockFileWindows.cpp

LockFileWindows::LockFileWindows (int fd)
     : LockFileBase (fd),
       m_file (reinterpret_cast<HANDLE> (_get_osfhandle (fd)))
 {
 }
 
 LockFileWindows::~LockFileWindows ()
 {
     Unlock ();
-    if (m_file != INVALID_HANDLE_VALUE)
-    {
-        ::CloseHandle (m_file);
-        m_file = INVALID_HANDLE_VALUE;
-    }
 }
 
 bool
 LockFileWindows::IsValidFile () const
 {
     return LockFileBase::IsValidFile() && m_file != INVALID_HANDLE_VALUE;
 }