This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] updates regular_invocable test to actually test regular_invocable
ClosedPublic

Authored by cjdb on Mar 24 2021, 4:15 PM.

Details

Summary

The test wasn't previously testing this concept, but its base.

Diff Detail

Event Timeline

cjdb requested review of this revision.Mar 24 2021, 4:15 PM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2021, 4:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Yipes. LGTM.

libcxx/test/std/concepts/callable/regularinvocable.compile.pass.cpp
30

These formatting changes are intended to improve consistency with invocable.compile.pass.cpp, I hope — not decrease consistency?

cjdb added inline comments.Mar 24 2021, 8:47 PM
libcxx/test/std/concepts/callable/regularinvocable.compile.pass.cpp
30

Good idea, I'll fix em up in the other one too, though it's moot due to some of your points in D96477.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2021, 11:34 PM
This revision was automatically updated to reflect the committed changes.