This is an archive of the discontinued LLVM Phabricator instance.

[asan] disable MallocNanoZone for no fd test on darwin
ClosedPublic

Authored by aralisza on Mar 16 2021, 12:20 PM.

Details

Summary

On Darwin, MallocNanoZone may log after execv, which messes up this test.
Disable MallocNanoZone for this test since we don't use it anyway with asan.

This environment variable should only affect Darwin and not change behavior on other platforms.

rdar://74992832

Diff Detail

Event Timeline

aralisza requested review of this revision.Mar 16 2021, 12:20 PM
aralisza created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2021, 12:20 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aralisza edited the summary of this revision. (Show Details)Mar 16 2021, 12:26 PM
aralisza updated this revision to Diff 331068.Mar 16 2021, 12:29 PM

better comment

aralisza edited the summary of this revision. (Show Details)Mar 16 2021, 12:34 PM
aralisza edited the summary of this revision. (Show Details)
aralisza edited the summary of this revision. (Show Details)
aralisza edited the summary of this revision. (Show Details)
aralisza edited the summary of this revision. (Show Details)Mar 16 2021, 1:28 PM
aralisza updated this revision to Diff 331095.Mar 16 2021, 1:33 PM

actually include change this time

This revision is now accepted and ready to land.Mar 16 2021, 3:13 PM
This revision was automatically updated to reflect the committed changes.