Page MenuHomePhabricator

dotest.py - debug feature that helps find dosep races
ClosedPublic

Authored by vharron on May 19 2015, 7:47 PM.

Details

Summary

dosep.py starts lots and lots of dotest instances.

This option helps you find if two (or more) dotest instances are using
the same directory at the same time.

Enable it to cause test failures and stderr messages if dotest
instances try to run in the same directory simultaneously.

It is disabled by default because it litters the test directories with
".dirlock" files

Diff Detail

Repository
rL LLVM

Event Timeline

vharron updated this revision to Diff 26114.May 19 2015, 7:47 PM
vharron retitled this revision from to dotest.py - debug feature that helps find dosep races.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added reviewers: clayborg, labath.
vharron added a subscriber: Unknown Object (MLST).
labath accepted this revision.May 20 2015, 1:31 AM
labath edited edge metadata.

LGTM.
I have been also worried by this problem, but manual code inspection assured me that this could not happen. It will be interesting to see if this finds anything, as some of the rare failures we're seeing do seem to hint at the possibility of something like this happening.

test/lldbtest.py
57 ↗(On Diff #26114)

How will you set this to true? Shouldn't we add a command line option, environment variable or something?

This revision is now accepted and ready to land.May 20 2015, 1:31 AM
This revision was automatically updated to reflect the committed changes.

I'll add a command line parameter in a followup CL (when we suspect this is a problem again)