This is an archive of the discontinued LLVM Phabricator instance.

[dfsan] Update fast16labels.ll test
ClosedPublic

Authored by gbalats on Mar 9 2021, 5:12 PM.

Details

Summary

Remove hard-coded shadow width references. Separate CHECK lines that only apply to fast16 mode.

Diff Detail

Event Timeline

gbalats requested review of this revision.Mar 9 2021, 5:12 PM
gbalats created this revision.
gbalats updated this revision to Diff 329504.Mar 9 2021, 5:14 PM

Fix typo in comment

llvm/test/Instrumentation/DataFlowSanitizer/fast16labels.ll
14–15
110

Add these patterns after fast8 code is checked in?

This file could be renamed to fast_labels.ll to support both 16 and 8 bit modes later.

gbalats added inline comments.Mar 9 2021, 5:36 PM
llvm/test/Instrumentation/DataFlowSanitizer/fast16labels.ll
14–15

I didn't change this as I intended to leave TLS alignment to 2. So far, I have been changing only alignments that are unrelated to @__dfsan_.*_tls stuff.

110

Yes. I agree about renaming. I intend to do it when introducing the fast8 mode.

llvm/test/Instrumentation/DataFlowSanitizer/fast16labels.ll
146

Since RUN commands do not use CHECK8 yet, please add them later when checking in the 8bit mode code change.

gbalats updated this revision to Diff 329726.Mar 10 2021, 12:02 PM

Remove CHECK8 lines.

gbalats marked an inline comment as done.Mar 10 2021, 12:02 PM
gbalats added inline comments.
llvm/test/Instrumentation/DataFlowSanitizer/fast16labels.ll
146

Removed.

gbalats marked an inline comment as done.Mar 10 2021, 12:03 PM
This revision is now accepted and ready to land.Mar 10 2021, 12:03 PM
gbalats edited the summary of this revision. (Show Details)Mar 10 2021, 12:04 PM
This revision was landed with ongoing or failed builds.Mar 10 2021, 12:13 PM
This revision was automatically updated to reflect the committed changes.