This is an archive of the discontinued LLVM Phabricator instance.

Choose stdlib for test suite based on target platform.
ClosedPublic

Authored by flackr on May 15 2015, 10:45 AM.

Details

Summary

When compiling programs for the test suite we currently choose which stdlib to use based on the host platform, but should be basing this on the target platform.

Diff Detail

Repository
rL LLVM

Event Timeline

flackr updated this revision to Diff 25877.May 15 2015, 10:45 AM
flackr retitled this revision from to Choose stdlib for test suite based on target platform..
flackr updated this object.
flackr edited the test plan for this revision. (Show Details)
flackr added a reviewer: clayborg.
flackr set the repository for this revision to rL LLVM.
flackr added a subscriber: Unknown Object (MLST).
clayborg requested changes to this revision.May 15 2015, 11:06 AM
clayborg edited edge metadata.

A few changes, See inlined comments.

test/lldbtest.py
1687

use

self.platformIsDarwin()

instead of:

self.getPlatform() in getDarwinOSTriples()
1737

use `self.platformIsDarwin()`

1824

use `self.platformIsDarwin()`

1841

use `self.platformIsDarwin()`

This revision now requires changes to proceed.May 15 2015, 11:06 AM
flackr updated this revision to Diff 25883.May 15 2015, 11:37 AM
flackr edited edge metadata.

Use platformIsDarwin instead of manually checking if the platform is in darwin triples.

And done in one more location that slipped by before :-).

test/lldbtest.py
1687

Done.

1737

Done.

1824

Done.

1841

Done.

clayborg accepted this revision.May 15 2015, 11:38 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.May 15 2015, 11:38 AM
This revision was automatically updated to reflect the committed changes.