Page MenuHomePhabricator

[Polly] Refabricating IsOutermostParallel() from Integer Set Libarary(ISL) to take the C++ wrapper
ClosedPublic

Authored by prateekpardeshi on Mar 1 2021, 5:59 PM.

Details

Summary

Polly use algorithms from the Integer Set Library (isl), which is a library written in C and which is incompatible with the rest of the LLVM as it is written in C++.

Changes made:

  • Refabricating IsOutermostParallel() to take C++ bindings instead of reference-counting in C isl lib.
  • Addition of manage_copy() to be used as reference for C objects instead of IsOutermostParallel()

Diff Detail

Event Timeline

prateekpardeshi created this revision.Mar 1 2021, 5:59 PM
prateekpardeshi requested review of this revision.Mar 1 2021, 5:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2021, 5:59 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Meinersbur requested changes to this revision.Mar 2 2021, 12:03 AM

The build failed because the formatting is not right (see "Lint: Pre-merge checks" message). You can run ninja polly-update-format to automatically fix it, then update the diff of this review.

compiler-rt/lib/hwasan/hwasan_flags.inc
83 ↗(On Diff #327334)

Unrelated change; please remove from the diff

This revision now requires changes to proceed.Mar 2 2021, 12:03 AM
prateekpardeshi removed a subscriber: Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2021, 12:12 AM
prateekpardeshi accepted this revision.Mar 2 2021, 12:17 AM

Ran ninja polly-update-format and updated diff while removing unrelated changes.

prateekpardeshi resigned from this revision.Mar 2 2021, 12:34 AM
Meinersbur accepted this revision.Mar 2 2021, 7:05 AM

LGTM. Thanks for the update.

Do you need assistance to land this change?

This revision is now accepted and ready to land.Mar 2 2021, 7:05 AM

Please merge this code if it seems okay. Thanks!