Page MenuHomePhabricator
Differential D97205

[lldb][NFC] Don't inherit from UserID in ValueObject
ClosedPublic
Actions

Authored by teemperor on Feb 22 2021, 9:34 AM.

Details

Reviewers
JDevlieghere
Group Reviewers
Restricted Project
Commits
rGd77e3c6aec29: [lldb][NFC] Don't inherit from UserID in ValueObject
Summary

ValueObject inherits from UserID which is just a bad idea:

  • The inheritance gives ValueObject some member functions that are at best misleading (such as Clear() which doesn't clear any value beside id).
  • It allows passing ValueObject to the overloaded operators for UserID (such as == or << which won't actually compare or print anything in the ValueObject).
  • It exposes the SetID and Clear which both allow users to change the internal id value.

Similar to D91699 which did the same for Process

Diff Detail

Event Timeline

teemperor created this revision.Feb 22 2021, 9:34 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptFeb 22 2021, 9:34 AM
teemperor requested review of this revision.Feb 22 2021, 9:34 AM
JDevlieghere accepted this revision.Feb 22 2021, 2:45 PM
This revision is now accepted and ready to land.Feb 22 2021, 2:45 PM
shafik added a subscriber: shafik.Feb 22 2021, 2:54 PM
shafik added inline comments.
lldb/include/lldb/Core/ValueObject.h
892

This makes more sense, ValueObject is not a UserID but contains one.

teemperor updated this revision to Diff 325708.Feb 23 2021, 1:14 AM
  • Rebased.
  • Add a GetID() call where we relied on the == overload before.
Closed by commit rGd77e3c6aec29: [lldb][NFC] Don't inherit from UserID in ValueObject (authored by teemperor). · Explain WhyFeb 23 2021, 1:16 AM
This revision was automatically updated to reflect the committed changes.
teemperor added a commit: rGd77e3c6aec29: [lldb][NFC] Don't inherit from UserID in ValueObject.
Herald added a subscriber: lldb-commits. · View Herald TranscriptFeb 23 2021, 1:16 AM

Revision Contents
Changeset List

PathSize
lldb/
include/
lldb/
Core/
8 lines
source/
Core/
11 lines
DataFormatters/
2 lines

Diff 325709

View Options

lldb/include/lldb/Core/ValueObject.h

Loading...
View Options

lldb/source/Core/ValueObject.cpp

Loading...
View Options

lldb/source/DataFormatters/TypeSynthetic.cpp

Loading...