Page MenuHomePhabricator

[lldb][NFC] Cleanup ValueObject construction code
ClosedPublic

Authored by teemperor on Feb 22 2021, 8:44 AM.

Details

Summary

Just code cleanup for ValueObject constructors:

  • Use default member initializers where possible.
  • Doxygenify the comments for membersa nd constructors where needed.
  • Delete the default constructor which isn't defined.
  • Initialize the bitfields via a utility struct instead of doing this in the different constructors.

Diff Detail

Event Timeline

teemperor requested review of this revision.Feb 22 2021, 8:44 AM
teemperor created this revision.
JDevlieghere added inline comments.Feb 22 2021, 8:51 AM
lldb/include/lldb/Core/ValueObject.h
913

I guess another option would be wrapping the bitfield in a struct and doing that it ints default ctor?

nice, deferring to Jonas to accept

teemperor updated this revision to Diff 325586.Feb 22 2021, 2:57 PM
  • Now using some utility struct (Thanks Jonas!)
teemperor edited the summary of this revision. (Show Details)Feb 23 2021, 12:04 AM
This revision is now accepted and ready to land.Feb 23 2021, 12:05 AM
This revision was automatically updated to reflect the committed changes.