This is an archive of the discontinued LLVM Phabricator instance.

[NativeProcessLinux] Fix potential race during thread exit
ClosedPublic

Authored by labath on May 12 2015, 2:23 AM.

Details

Summary

This is the same issue as we had in D9145 for thread creation. Going through the full
ThreadDidStop/RequestResume cycle can cause a deferred notification to fire, which is not correct
when we are ignoring an event and resuming the thread. In this case it doesn't matter much since
the thread will die after that anyway, but for correctness, we should do the same thing here.
Also treating the SIGTRAP case the same way.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 25562.May 12 2015, 2:23 AM
labath retitled this revision from to [NativeProcessLinux] Fix potential race during thread exit.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: chaoren, ovyalov.
labath added a subscriber: Unknown Object (MLST).
ovyalov accepted this revision.May 13 2015, 3:47 PM
ovyalov edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 13 2015, 3:47 PM
This revision was automatically updated to reflect the committed changes.