This is an archive of the discontinued LLVM Phabricator instance.

Differential D96374

[GWP-ASan] Add back some headers removed by IWYU.
ClosedPublic

Authored by hctim on Feb 9 2021, 2:55 PM.

Details

Reviewers
eugenis
Commits
rGb93786907c54: [GWP-ASan] Add back some headers removed by IWYU.
Summary

These headers are required for Android.

Diff Detail

Event Timeline

hctim requested review of this revision.Feb 9 2021, 2:55 PM
hctim created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 2:55 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
hctim updated this revision to Diff 322514.Feb 9 2021, 2:57 PM

Inline the definitions required only on Android.

Harbormaster completed remote builds in B88523: Diff 322512.Feb 9 2021, 3:29 PM
Harbormaster completed remote builds in B88525: Diff 322514.Feb 9 2021, 3:31 PM
eugenis accepted this revision.Feb 9 2021, 4:24 PM

LGTM
this iwyu thing seems actively harmful

This revision is now accepted and ready to land.Feb 9 2021, 4:24 PM
Closed by commit rGb93786907c54: [GWP-ASan] Add back some headers removed by IWYU. (authored by hctim). · Explain WhyFeb 10 2021, 9:14 AM
This revision was automatically updated to reflect the committed changes.
hctim added a commit: rGb93786907c54: [GWP-ASan] Add back some headers removed by IWYU..

Revision Contents

PathSize
compiler-rt/
lib/
gwp_asan/
platform_specific/
3 lines

Diff 322709

compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp

//===-- utilities_posix.cpp -------------------------------------*- C++ -*-===// //===-- utilities_posix.cpp -------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <sys/cdefs.h> // IWYU pragma: keep (for __BIONIC__ macro)
#ifdef __BIONIC__ #ifdef __BIONIC__
#include "gwp_asan/definitions.h"
#include <stdlib.h> #include <stdlib.h>
extern "C" GWP_ASAN_WEAK void android_set_abort_message(const char *); extern "C" GWP_ASAN_WEAK void android_set_abort_message(const char *);
#else // __BIONIC__ #else // __BIONIC__
#include <stdio.h> #include <stdio.h>
#endif #endif
namespace gwp_asan { namespace gwp_asan {
void die(const char *Message) { void die(const char *Message) {
Show All 10 Lines