This is an archive of the discontinued LLVM Phabricator instance.

TestCModules was effectively skipped on Linux
ClosedPublic

Authored by vharron on May 8 2015, 11:54 AM.

Reviewers

Commits

Summary

I've removed the secret skip and added expectedFailureLinux

vharron retitled this revision from to TestCModules was effectively skipped on Linux.

vharron updated this object.

vharron edited the test plan for this revision. (Show Details)

vharron added a reviewer: flackr.

vharron added a subscriber: Unknown Object (MLST).

lgtm, thanks

This revision is now accepted and ready to land.May 8 2015, 11:56 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

lang/

modules/

5 lines

Show All 16 Lines	class CModulesTestCase(TestBase):
@skipUnlessDarwin		@skipUnlessDarwin
@dsym_test		@dsym_test
def test_expr_with_dsym(self):		def test_expr_with_dsym(self):
self.buildDsym()		self.buildDsym()
self.expr()		self.expr()

@dwarf_test		@dwarf_test
@skipIfFreeBSD		@skipIfFreeBSD
		@expectedFailureLinux('http://llvm.org/pr23456') # 'fopen' has unknown return type
def test_expr_with_dwarf(self):		def test_expr_with_dwarf(self):
self.buildDwarf()		self.buildDwarf()
self.expr()		self.expr()

def setUp(self):		def setUp(self):
# Call super's setUp().		# Call super's setUp().
TestBase.setUp(self)		TestBase.setUp(self)
# Find the line number to break inside main().		# Find the line number to break inside main().
self.line = line_number('main.c', '// Set breakpoint 0 here.')		self.line = line_number('main.c', '// Set breakpoint 0 here.')

def applies(self):		def applies(self):
if platform.system() != "Darwin":		if platform.system() == "Darwin" and platform.release() < StrictVersion('12.0.0'):
return False
if StrictVersion('12.0.0') > platform.release():
return False		return False

return True		return True

def common_setup(self):		def common_setup(self):
exe = os.path.join(os.getcwd(), "a.out")		exe = os.path.join(os.getcwd(), "a.out")
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)		self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)

Show All 37 Lines