Page MenuHomePhabricator

We can only move static allocas into the resume entry points
ClosedPublic

Authored by aschwaighofer on Feb 4 2021, 11:54 AM.

Details

Summary

Dynamic allocas that still exist have been verified to be only used
'locally' not accross a suspend point.

rdar://73903220

Diff Detail

Event Timeline

aschwaighofer created this revision.Feb 4 2021, 11:54 AM
aschwaighofer requested review of this revision.Feb 4 2021, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2021, 11:54 AM
rjmccall accepted this revision.Feb 4 2021, 1:08 PM

The idea in this test case is that this gets lowered to a dynamic alloca before the code that adjusts for the entry point sees it? That might be worth spelling out in the test case. Otherwise LGTM.

This revision is now accepted and ready to land.Feb 4 2021, 1:08 PM

Add comment to test case.

This revision was landed with ongoing or failed builds.Feb 5 2021, 6:08 AM
This revision was automatically updated to reflect the committed changes.